Dev remove roslyn nupkg ref #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HongGit
reviewed
Jan 19, 2018
| </NuGetContent> | ||
| <NuGetContent Include="build\net46\*"> | ||
| <Destination>build\net46</Destination> | ||
| </NuGetContent> | ||
| <NuGetContent Include="tools\*.ps1"> | ||
| <Destination>tools\net45</Destination> |
There was a problem hiding this comment.
any reason that this is the same as net45?
There was a problem hiding this comment.
anything under net45 folder will apply to project targeting 4.5+, if there is no other netxx folder in nupkg. The install.ps1 works in the same way no matter of the targeting framework.
HongGit
reviewed
Jan 19, 2018
| <Destination>build\net45</Destination> | ||
| </NuGetContent> | ||
| <NuGetContent Include="build\net46\*"> | ||
| <Destination>build\net46</Destination> |
There was a problem hiding this comment.
I am assuming this the latest you are referring later? So this should cover anything after 4.6, correct? If so, do you want to use latest here as well?
There was a problem hiding this comment.
net46 folder name has special meaning in Nupkg. Check this.
HongGit
approved these changes
Jan 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the dependency of Microsoft.Net.Compilers nupkg, instead embed the Roslyn bits inside CodeDomProvider nupkg. This will ensure VS always use the Roslyn compiler shipped with msbuild. Developer can also specify a path through the following msbuild property from which CodeDomProvider copies the Roslyn compilers to bin\roslyn folder.
[some path]