Added sperate option "IUrlHelper and support for RouteOptions.Lowerca…

…seUrls " @rynowak #518 #Issue: aspnet/Mvc#7720
aspnet · Jun 1, 2018 · f227cbe · f227cbe
1 parent 695fb00
commit f227cbe
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 6 deletions.
diff --git a/src/Microsoft.AspNetCore.Routing/RouteCollection.cs b/src/Microsoft.AspNetCore.Routing/RouteCollection.cs
@@ -139,7 +139,7 @@ private VirtualPathData NormalizeVirtualPath(VirtualPathData pathData)
 
             var url = pathData.VirtualPath;
 
-            if (!string.IsNullOrEmpty(url) && (_options.LowercaseUrls || _options.AppendTrailingSlash))
+            if (!string.IsNullOrEmpty(url) && (_options.LowercaseUrls || _options.LowercaseQueryStrings || _options.AppendTrailingSlash))
             {
                 var indexOfSeparator = url.IndexOfAny(UrlQueryDelimiters);
                 var urlWithoutQueryString = url;
@@ -154,11 +154,11 @@ private VirtualPathData NormalizeVirtualPath(VirtualPathData pathData)
                 if (_options.LowercaseUrls)
                 {
                     urlWithoutQueryString = urlWithoutQueryString.ToLowerInvariant();
+                }
 
-                    if (!string.IsNullOrEmpty(queryString))
-                    {
-                        queryString = queryString.ToLowerInvariant();
-                    }
+                if (_options.LowercaseQueryStrings)
+                {
+                    queryString = queryString.ToLowerInvariant();
                 }
 
                 if (_options.AppendTrailingSlash && !urlWithoutQueryString.EndsWith("/"))

diff --git a/src/Microsoft.AspNetCore.Routing/RouteOptions.cs b/src/Microsoft.AspNetCore.Routing/RouteOptions.cs
@@ -10,10 +10,15 @@ namespace Microsoft.AspNetCore.Routing
     public class RouteOptions
     {
         /// <summary>
-        /// Gets or sets a value indicating whether all generated URLs are lower-case.
+        /// Gets or sets a value indicating whether all generated URLs are lower-case. it doesn't include the query string.
         /// </summary>
         public bool LowercaseUrls { get; set; }
 
+        /// <summary>
+        /// Gets or sets a value indicating whether all generated QUERY STRINGS are lower-case.
+        /// </summary>
+        public bool LowercaseQueryStrings { get; set; }
+
         /// <summary>
         /// Gets or sets a value indicating whether a trailing slash should be appended to the generated URLs.
         /// </summary>