This repository has been archived by the owner on Nov 27, 2018. It is now read-only.
Implement a 'required' constraint #79
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful for a variety of interesting scenarios in link generation where a default value doesn't appear in the route template as a parameter. This can be used to implement the desired behavior for areas - where the 'area' key is sticky.
This was referenced Jul 8, 2014
| @@ -49,6 +49,9 @@ public class RouteOptions | |||
| { "maxlength", typeof(MaxLengthRouteConstraint) }, | |||
| { "length", typeof(LengthRouteConstraint) }, | |||
|
|
|||
| // Required-value constraints | |||
| { "required", typeof(RequiredConstraint) }, | |||
There was a problem hiding this comment.
What does this mean as an inline constraint? Once you have a slug, isn't it required by default?
There was a problem hiding this comment.
That's true, I did it for completeness but I can't really think of a reason why it would be useful.
There's some weird stuff you can do with it, but nothing super helpful.
|
PR updated, please take a look |
|
/cc @harshgMSFT |
| /// This constraint is primarily used to enforce that a non-parameter value is present during | ||
| /// URL generation. | ||
| /// </remarks> | ||
| public class RequiredConstraint : IRouteConstraint |
There was a problem hiding this comment.
Consider renaming to RequiredRouteConstraint all other constraints follow this convention.
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful for a variety of interesting scenarios in link generation
where a default value doesn't appear in the route template as a parameter.
This can be used to implement the desired behavior for areas - where the
'area' key is sticky.