-
Notifications
You must be signed in to change notification settings - Fork 25
Using 'nameof' operator instead of magic string #8
Conversation
Hi @hishamco, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! The agreement was validated by .NET Foundation and real humans are currently evaluating your PR. TTYL, DNFBOT; |
/cc @Eilon |
@@ -37,7 +37,7 @@ public void RetryRetriesActionOnStandardException() | |||
{ | |||
++called; | |||
if (called < 2) | |||
throw new Exception("Error"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is wrong. This Exception
ctor takes a message as the parameter and not parameter name. This change does not add any value and actually makes the code more confusing. Same applies to changes below.
(From what I see a good change in this file would be to remove ref
from the ref int called
parameter on the RetryHelper
method - it does not seem to be changed inside the method and therefore does not have to be ref
- the tests still must build and pass after the change).
@Eilon can you have a look and merge if it's fine |
1 similar comment
@Eilon can you have a look and merge if it's fine |
We're no longer building this repo. |
No description provided.