Skip to content
This repository has been archived by the owner on Dec 18, 2018. It is now read-only.

Support for InvokeAsync #2926

Closed
analogrelay opened this issue Sep 7, 2018 · 3 comments
Closed

Support for InvokeAsync #2926

analogrelay opened this issue Sep 7, 2018 · 3 comments
Assignees
Labels
client: Java cost: M Will take 3 - 5 days to complete PRI: 1 - Required Must be handled in a reasonable time
Milestone

Comments

@analogrelay
Copy link
Contributor

We only support SendAsync-style invocation in the Java Client right now. We need support for waiting for the server to finish the invocation.

@analogrelay analogrelay added cost: M Will take 3 - 5 days to complete PRI: 1 - Required Must be handled in a reasonable time client: Java labels Sep 7, 2018
@analogrelay analogrelay added this to the 2.2.0 milestone Sep 7, 2018
@BrennanConroy BrennanConroy self-assigned this Sep 11, 2018
@BrennanConroy
Copy link
Member

Small issue with invoke, Java generics are really great so we need to pass the class type of the return value into the function call.

public <T> T invoke(String target, Class<T> returnType, Object... args);
Are we ok with that signature, or is there a different way we can do this. @anurse @mikaelm12

@analogrelay
Copy link
Contributor Author

Sounds like this is the way we have to do it, so let's do it. I wonder if we should put the return type first?

.invoke(String.class, "GetProductName", 123, 456);

vs

.invoke("GetProductName", String.class, 123, 456);

I like the first one (return type first) because a) it looks closer to the C# and b) it keeps the method name and args together.

@BrennanConroy
Copy link
Member

4b37869

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
client: Java cost: M Will take 3 - 5 days to complete PRI: 1 - Required Must be handled in a reasonable time
Projects
None yet
Development

No branches or pull requests

2 participants