This repository has been archived by the owner on Dec 18, 2018. It is now read-only.
Retry redis docker #3265
Merged
Retry redis docker #3265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muratg
reviewed
Nov 6, 2018
| } | ||
| catch (Exception ex) | ||
| { | ||
| logger.LogError(ex, "Error starting redis docker container, retrying."); |
There was a problem hiding this comment.
Wouldn't this be a possible infinite loop?
Do we want a counter and give up after N retries?
There was a problem hiding this comment.
It only calls Run twice, no looping
There was a problem hiding this comment.
Yeah, it's not recursive, it just looks kinda like it is because of the local func ;).
Add a delay? Just a second or two.
There was a problem hiding this comment.
Synchronous delay :(
There was a problem hiding this comment.
Actually yeah, leave it in. It's OK here
analogrelay
approved these changes
Nov 6, 2018
| } | ||
| catch (Exception ex) | ||
| { | ||
| logger.LogError(ex, "Error starting redis docker container, retrying."); |
There was a problem hiding this comment.
Yeah, it's not recursive, it just looks kinda like it is because of the local func ;).
Add a delay? Just a second or two.
analogrelay
approved these changes
Nov 6, 2018
| } | ||
| catch (Exception ex) | ||
| { | ||
| logger.LogError(ex, "Error starting redis docker container, retrying."); |
muratg
approved these changes
Nov 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3256
cc @muratg Test only 2.2 change