This repository has been archived by the owner on Oct 18, 2018. It is now read-only.
Cache Coherence locally in ci-test. #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| if (!string.IsNullOrWhiteSpace(dropsShare)) | ||
| { | ||
| var coherenceShare = Path.Combine(dropsShare, "Coherence", BUILD_BRANCH); |
There was a problem hiding this comment.
I'm wondering if this can fail if you get a partially pushed coherence... Maybe coherence should drop a file as the final step and we should look only at the folders that have that file
|
I think it's okay. |
|
Went with a slightly different approach: I'm keeping the Coherence build number in the cached directory. If I see there's already a cache for that build number, I don't try to copy it over again. |
cesarblum
force-pushed
the
cesarbs/cache-coherence
branch
from
c8eddfa
to
b269e3f
Compare
cesarblum
changed the title
| Log.Info("Coherence build " + latestBuild + " already cached at " + targetDir + "."); | ||
| } | ||
|
|
||
| Environment.SetEnvironmentVariable("NUGET_VOLATILE_FEED_ASPNETVNEXT", Path.Combine(targetDir, "build")); |
There was a problem hiding this comment.
Caching the nupkgs as-is is not super nice for perf especially given the directory has close to 600 nupkgs. You should probably expand it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #304.
Still needs a bit more testing.
cc @victorhurdugaci @pranavkm