This repository has been archived by the owner on Oct 18, 2018. It is now read-only.
Upgrade Remotion.Linq dependency to RTM #854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natemcmaster
approved these changes
Feb 7, 2018
| @@ -354,11 +353,6 @@ | |||
| <ExternalDependency Include="StackExchange.Redis.StrongName" Version="$(StackExchangeRedisStrongNamePackageVersion)" Source="$(DefaultNuGetFeed)" /> | |||
| <ExternalDependency Include="StreamJsonRpc" Version="$(StreamJsonRpcPackageVersion)" Source="$(DefaultNuGetFeed)" /> | |||
| <ExternalDependency Include="StyleCop.Analyzers" Version="$(StyleCopAnalyzersPackageVersion)" Source="$(DefaultNuGetFeed)" Private="true" /> | |||
| <ExternalDependency Include="System.Data.SqlClient" Version="$(Benchmarks_11_SystemDataSqlClientPackageVersion)" Source="$(DefaultNuGetFeed)" Private="true"> | |||
| <!-- This version is used by EF's 1.1 benchmark project --> | |||
| <NoWarn>KRB2004</NoWarn> | |||
There was a problem hiding this comment.
Can you also remove the NoWarn on the other System.Data.SqlClient package in this list? Should be unnecessary now.
smitpatel
force-pushed
the
smit/relinq
branch
from
45d8855
to
8bd597a
Compare
|
@natemcmaster - When will these changes propagate to EF repo? Is there any manual step required to do so? |
|
Normally, over the weekend our automation would update EFCore. But, you can do this manually yourself now that your change made it into a build and is on myget. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves dotnet/efcore#9311
@Eilon - for approval
cc: @ajcvickers @natemcmaster