Start of an Asp.Net Core port #47

rposener · 2016-03-06T17:07:15Z

Haven't had a lot of time to do much else, yet. Coming weeks should provide more options. Any chance you guys will be at Build event? Would like to see a V1 of this published as nupkg's by then. If you guys can provide some guidance / how IServiceCollection should/should not be used, etc. that would be helpful. Also, should it leverage the HttpRequest ApplicationServices property to do all resolution? Do we need the Default Service functionality, or should that be handled as a default during registration using an option lambda on the extension method for Configuring WebHooks?

davidfowl · 2016-03-06T17:55:25Z

src/Microsoft.AspNetCore.WebHooks.Common/Extensions/ServiceProviderExtensions.cs

+    /// Extension methods for <see cref="IDependencyScope"/> facilitating getting the services used by custom WebHooks.
+    /// </summary>
+    [EditorBrowsable(EditorBrowsableState.Never)]
+    public static class DependencyScopeExtensions


Too much service locator. Can these be properly injected?

rposener · 2016-03-08T16:30:39Z

Does this look more in line with the approach you would expect?

rposener · 2016-03-28T14:59:30Z

Just a note about couple items that need input / review:

IOptions/IConfiguration setup for secrets / settings
CustomWebHookReceiver can't seem to read request body (it's all default initialized bytes of 0) not sure what I've missed on that?
Configuration Extensions of Services / Resolution of Services may need some revision - was not sure how to setup configuration extensions with options Action to pass in configuration
Error Handling for various accept types in the MiddleWare (I changed all exceptions to use a custom Exception type to specify status code + message) since HttpResponseException is not part of ASP.Net Core.

davidfowl · 2016-03-31T08:27:24Z

src/Microsoft.AspNetCore.WebHooks.Receivers/Middleware/WebHookReceiverMiddleware.cs

@@ -57,12 +57,14 @@ public static void ConfigureMapping(IApplicationBuilder app)
        /// <returns></returns>
        private static async Task ProcessWebHook(HttpContext context, string webHookReceiver, string id)


I would change this into a proper middleware class so that dependencies can be injected once instead of being pulled out of the container manually.

Question: Should I revise the entire thing to merge the managers into the middleware, Simplifying the entire model? Basically have Middleware > Receivers > Handlers? This feels like a much simpler approach and having been through enough now, this may make for a simpler solution.

rposener · 2016-04-20T17:41:44Z

Any further information / details regarding this? Does it need to get updated to the current dev branch / RC2? Is it a good time to do that, or should we hold off until it releases?

HenrikFrystykNielsen · 2016-04-20T18:06:11Z

I am sorry it takes so long. I have poked the 'core' folks but I think they are busy. Will try again.

Eilon · 2016-05-17T06:03:56Z

.gitignore

@@ -18,3 +18,5 @@ _[Ss]cripts
 *.dot[Cc]over
 *.pubxml
 *.zip
+/coresamples/CoreCustomSender/project.lock.json


Should just exclude all project.lock.json files - no need to check them in for this repo.

Eilon · 2016-05-17T06:47:00Z

{

This file shouldn't be needed; the root folder's global.json should be enough.

Refers to: src/Microsoft.AspNetCore.WebHooks.Common/global.json:1 in 1b1edb7. [](commit_id = 1b1edb7, deletion_comment = False)

Eilon · 2016-05-17T06:48:16Z

src/Microsoft.AspNetCore.WebHooks.Common/Extensions/DictionaryExtensions.cs

+    /// Extension methods for <see cref="IDictionary{TKey,TValue}"/>.
+    /// </summary>
+    [EditorBrowsable(EditorBrowsableState.Never)]
+    public static class DictionaryExtensions


All these extension methods types need to be internal. We don't want them "leaking out" of this assembly.

Used anywhere?

Eilon · 2016-05-17T07:19:13Z

Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Src.AspNetCore", "Src.AspNetCore", "{668B3959-3928-472F-9341-06BF8C9BADE9}"

I might just be misreading the SLN file, but are the names and paths of the projects here correct?

Refers to: WebHooks.sln:145 in 1b1edb7. [](commit_id = 1b1edb7, deletion_comment = False)

Eilon · 2016-05-17T07:20:03Z

samples/CustomSender.AspNetCore/WebHooks/CustomFilterProvider.cs

+    public class CustomFilterProvider : IWebHookFilterProvider
+    {
+        private readonly Collection<WebHookFilter> filters = new Collection<WebHookFilter>
+    {


Formatting got messed up here.

Added WebHookNotification Classes

rposener · 2016-05-23T22:40:33Z

OK I've updated my fork with a bunch of new projects for the core stuff. I have a few questions that I need some input on.

For Receivers Middleware now calls Receivers, which produce a Context if the Handlers should be called. If no handler should be called (e.g. echo/Validation) then it just returns null. Otherwise, they set the context, or in error situation throw.
All options are set via IOptions, and ServiceCollectionExtensions and MiddlewareExtensions have a setupAction to apply conifguration options as necessary.
NotificationDictionary is now IWebHookNotification (I created 2 classes to support existing items, but should provide nice options for DTO's for WebHooks.
Resources are not loading - trying to test sending of custom notification seems to die. Not sure what/how I've messed up resources. Any information anyone can provide would be helpful.
Overall it converted much easier on RC2, some is just my experience with asp.net core growing, some is the tooling!
Items not necessary for asp.net core have been omitted. Projects should be setup a bit cleaner now.

rposener · 2016-05-24T10:56:24Z

Figured out my Resource Loading issue (https://github.com/dotnet/corefx/issues/8754)

Registrars as Optional (Resolve on Demand) Custom Subscribe/Unsubscribe / Notification working

rposener · 2016-05-24T16:37:12Z

Ok - custom senders and receivers are working with all the same interfaces implemented. I have not made my way back to writing tests, but generally all the same tests as the .net project should be passing.

Question for Henrik - I had not paid attention to the Registrars before. It doesn't look like any sample or other project implements them. Is that there just in case someone needs to do some additional verification? I also did not really get the point of the IdValidator along the same lines. Could those not be just consolidated into a single validator, and leave it up to the implementation to decide what to validate?

I am heading out on Vacation till next Tuesday. If you guys can give this a bit of a review (Eilon) in the mean time, I will start on converting the tests, and look at updating the other receivers, which should not take too much effort to crank through.

Updated Service Configuration with comments to show use

MisterJames · 2016-06-21T21:00:52Z

@rposener @HenrikFrystykNielsen Hey folks, no milestone here, but it looks like it's getting close? Is there an ETA for this PR to get merged?

rposener · 2016-06-23T04:18:22Z

Well, I have had some time away where I was unable to work on it. Should be able to get more done soon. Kind of wish I could get some review from the asp.net core team to know if middleware is looking OK, and from Henrik based on questions above. Certainly is close - just want a little confidence I'm not severely overlooking something. If it's good, then we should be able to just start porting all the implementations and tests.

Or perhaps, the team wants it to be a single project that targets both frameworks. If that is the case, a lot of refactoring is probably needed... Open to input, and would love some feedback.

rposener · 2016-07-12T14:07:42Z

Should I just close this and let someone else start again?

HenrikFrystykNielsen · 2016-07-12T14:12:50Z

I really appreciate all the work you have put into it and I apologize for the lack of response. Part of it has been because core has been in flux but with core 1.0 out it should be possible to get a stable model together. I absolutely do want this to run on core but it has been difficult to get things to align. Let me chat with some of the core folks and see how we can bring your work forward. thanks!

tutukar · 2016-08-15T19:00:31Z

Any word on if and when this branch is going to be merged to master? We have a Webhook based running we are looking to Migrate to .net core. Thanks!

invisibleaxm · 2016-09-15T02:36:51Z

+1 it would be awesome if we can start developing webhooks in .net core

dalestone · 2016-09-19T17:35:38Z

Any further update on this? It would be great if we could use WebHooks in .NET core

binaryPUNCH · 2016-09-27T15:33:07Z

I'm super excited for this! Any eta?

yilativ · 2016-09-30T15:16:57Z

Anyone try this yet?

dkent600 · 2016-11-07T20:27:27Z

It seems no one is paying attention

CharlBest · 2016-12-09T11:17:37Z

This would be very cool indeed

alhardy · 2017-01-10T23:42:26Z

We have a project were this would be very useful, hesitant to use it though because there doesn't appear to be much recent work done on the project, is work going to continue on the project?

HenrikFrystykNielsen · 2017-01-12T05:37:13Z

It is on the road map but the stars haven't aligned yet to make it come together. I will provide an update when that happens. Thanks! Henrik

tutukar · 2017-03-03T22:34:39Z

Anything on this yet?

henningst · 2017-03-20T09:11:20Z

When can we expect to get WebHooks support in ASP.NET Core? This blog post says:

A port to the ASP.NET Core is being planned so please stay tuned!

Could you share any more details on that?

@HenrikFrystykNielsen

Eilon · 2017-10-06T20:55:28Z

Closing this PR because we're going with #153 instead. Thanks!

ghost · 2018-10-05T16:49:21Z

Webhook is not working for ASP.NET core 2.1 with GitHub. Does any one have any working samples.

Eilon · 2018-10-05T17:08:00Z

@ALMWEARE please log a new issue with details.

dnfclas added the cla-already-signed label Mar 6, 2016

davidfowl reviewed Mar 6, 2016
View reviewed changes

Eilon self-assigned this Mar 28, 2016

davidfowl reviewed Mar 31, 2016
View reviewed changes

Eilon reviewed May 17, 2016
View reviewed changes

Custom Sender Work

955c9a9

Added WebHookNotification Classes

rposener added 2 commits May 24, 2016 05:00

Fix Resource File Issues

ff88252

Registration and Filter Controller in Custom.Api Project

2dcb4d0

Registrars as Optional (Resolve on Demand) Custom Subscribe/Unsubscribe / Notification working

rposener added 4 commits May 24, 2016 11:05

Sql WebHooks Store

fcf3497

Updated Service Configuration with comments to show use

Common Tests which could be easily converted

679a76e

Common Test Utilities which could be easily converted

1cacef8

Updates to Custom Project based on Converted Tests

f46df8b

Eilon closed this Oct 6, 2017

dougbu mentioned this pull request Nov 11, 2017

Flesh out ASP.NET Core sender packages #183

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Start of an Asp.Net Core port #47

Start of an Asp.Net Core port #47

rposener commented Mar 6, 2016

davidfowl Mar 6, 2016

rposener commented Mar 8, 2016

rposener commented Mar 28, 2016

davidfowl Mar 31, 2016

rposener Mar 31, 2016

rposener commented Apr 20, 2016

HenrikFrystykNielsen commented Apr 20, 2016

Eilon May 17, 2016

Eilon commented May 17, 2016

Eilon May 17, 2016

Eilon May 17, 2016

Eilon commented May 17, 2016

Eilon May 17, 2016

rposener commented May 23, 2016 •

edited

rposener commented May 24, 2016

rposener commented May 24, 2016

MisterJames commented Jun 21, 2016

rposener commented Jun 23, 2016

rposener commented Jul 12, 2016

HenrikFrystykNielsen commented Jul 12, 2016

tutukar commented Aug 15, 2016

invisibleaxm commented Sep 15, 2016

dalestone commented Sep 19, 2016

binaryPUNCH commented Sep 27, 2016 •

edited

yilativ commented Sep 30, 2016

dkent600 commented Nov 7, 2016

CharlBest commented Dec 9, 2016

alhardy commented Jan 10, 2017

HenrikFrystykNielsen commented Jan 12, 2017

tutukar commented Mar 3, 2017

henningst commented Mar 20, 2017

Eilon commented Oct 6, 2017

ghost commented Oct 5, 2018

Eilon commented Oct 5, 2018

		@@ -57,12 +57,14 @@ public static void ConfigureMapping(IApplicationBuilder app)
		/// <returns></returns>
		private static async Task ProcessWebHook(HttpContext context, string webHookReceiver, string id)

Start of an Asp.Net Core port #47

Start of an Asp.Net Core port #47

Conversation

rposener commented Mar 6, 2016

davidfowl Mar 6, 2016

Choose a reason for hiding this comment

rposener commented Mar 8, 2016

rposener commented Mar 28, 2016

davidfowl Mar 31, 2016

Choose a reason for hiding this comment

rposener Mar 31, 2016

Choose a reason for hiding this comment

rposener commented Apr 20, 2016

HenrikFrystykNielsen commented Apr 20, 2016

Eilon May 17, 2016

Choose a reason for hiding this comment

Eilon commented May 17, 2016

Eilon May 17, 2016

Choose a reason for hiding this comment

Eilon May 17, 2016

Choose a reason for hiding this comment

Eilon commented May 17, 2016

Eilon May 17, 2016

Choose a reason for hiding this comment

rposener commented May 23, 2016 • edited

rposener commented May 24, 2016

rposener commented May 24, 2016

MisterJames commented Jun 21, 2016

rposener commented Jun 23, 2016

rposener commented Jul 12, 2016

HenrikFrystykNielsen commented Jul 12, 2016

tutukar commented Aug 15, 2016

invisibleaxm commented Sep 15, 2016

dalestone commented Sep 19, 2016

binaryPUNCH commented Sep 27, 2016 • edited

yilativ commented Sep 30, 2016

dkent600 commented Nov 7, 2016

CharlBest commented Dec 9, 2016

alhardy commented Jan 10, 2017

HenrikFrystykNielsen commented Jan 12, 2017

tutukar commented Mar 3, 2017

henningst commented Mar 20, 2017

Eilon commented Oct 6, 2017

ghost commented Oct 5, 2018

Eilon commented Oct 5, 2018

rposener commented May 23, 2016 •

edited

binaryPUNCH commented Sep 27, 2016 •

edited