Skip to content
This repository has been archived by the owner on Dec 18, 2017. It is now read-only.

Add '--in-place' option for "kpm wrap" #964

Closed
ChengTian opened this issue Dec 4, 2014 · 2 comments
Closed

Add '--in-place' option for "kpm wrap" #964

ChengTian opened this issue Dec 4, 2014 · 2 comments

Comments

@ChengTian
Copy link
Contributor

kpm wrap --in-place generates project.json in the same folder as given csproj file. Once this option is specified, it is also implicitly applied to wrap operations for all csprojs referenced by given csproj.

@ChengTian
Copy link
Contributor Author

@davidfowl , do we want to do the following thing?

kpm pack <csproj_path> --in-place also checks whether <csproj_path> is inside sources dirs specified in global.json. If not, we add it into sources of global.json.

Sometimes it can be confusing if a user does a successful kpm wrap --in-place but he still failed to reference the wrapped project, when he forgets to add the project dir into global.json sources.

@davidfowl
Copy link
Member

Yes, it needs to work the same way.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants