This repository has been archived by the owner on Dec 18, 2017. It is now read-only.
Add '--in-place' option for "kpm wrap" #970
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| string targetProjectJson; | ||
| if (InPlace) | ||
| { | ||
| targetProjectJson = Path.Combine(projectDir, "project.json"); |
There was a problem hiding this comment.
Why aren't you using Runtime.Project.ProjectFileName?
|
@davidfowl , this is for Beta3. Please sign off at your earliest convenience. |
ChengTian
force-pushed
the
kpm-wrap-in-place
branch
from
483c939
to
f045ce4
Compare
ChengTian
force-pushed
the
kpm-wrap-in-place
branch
from
f045ce4
to
886ed15
Compare
|
We need to do this in release branch. Please checkout #1125 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parent #964
Functional tests for
kpm wrap --in-placewill be added after #956 is merged.