This repository has been archived by the owner on May 31, 2019. It is now read-only.
Update for 1.1.1/1.0.4 and remove project.json images #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
natemcmaster
commented
Feb 28, 2017
1.1/jessie/sdk/Dockerfile
Outdated
| @@ -1,11 +1,11 @@ | |||
| FROM microsoft/dotnet:1.1.0-sdk-msbuild-rc4 | |||
| FROM microsoft/dotnet-nightly:1.1.1-sdk | |||
There was a problem hiding this comment.
Step 1/8 : FROM microsoft/dotnet-nightly:1.1.1-sdk
manifest for microsoft/dotnet-nightly:1.1.1-sdk not found
There was a problem hiding this comment.
Any ideas? This tag is listed on docker hub.
There was a problem hiding this comment.
Docker Hub is currently down at the moment - http://status.docker.com/
|
Shouldn't it be patch 1.1.2 |
|
@BrennanConroy good catch. The package cache version is "1.1.2", but we're keeping the image versions aligned with the dotnet images and the runtime version. |
MichaelSimons
approved these changes
Feb 28, 2017
1.1/jessie/sdk/README.md
Outdated
| @@ -60,7 +56,7 @@ With this technique your application is compiled when you run `docker build` and | |||
| FROM microsoft/aspnetcore-build | |||
| WORKDIR /app | |||
|
|
|||
| COPY project.json . | |||
| COPY MyApp.csproj . | |||
There was a problem hiding this comment.
Not sure what I think about this, but would it make sense to use *.csproj here as a way to abstract the Dockerfile?
There was a problem hiding this comment.
Yeah, good idea. Makes it more copy+paste friendly too.
natemcmaster
force-pushed
the
namc/feb-patch
branch
2 times, most recently
from
70d0578
to
8e43b77
Compare
Update packagecache to use the "Feburary 2017" patch release Update crossgen caches in runtime images Update README.md examples Remove the crossgen cache from the build image
natemcmaster
force-pushed
the
namc/feb-patch
branch
from
1de401f
to
7837f62
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update packagecache to use the "Feburary 2017" patch release
Update crossgen caches
Update README.md examples.
Resolves #203
Resolves #200