-
Notifications
You must be signed in to change notification settings - Fork 171
Add build of libuv for supporting Kestrel Web Server #8
Conversation
+1 for merge. Thanks for the Kestrel Support. It worked for me. |
@aminjam thanks for trying! |
@muojp great work here, thanks! I confirmed it enables
samples while running inside docker containers. @muojp can you indent lines 15-19 in dockerfiles with one tab to stay consistent with the rest of the file? LGTM! cc: @davidfowl to merge once he's happy. |
@ahmetalpbalkan thanks for trying out and pointing out indent mismatch. I fixed indent (spaces -> tab), squashed changes and force pushed 🍰 |
Great work! It works for me as well even with my +1 for merge 👍 |
@muojp Did you fill out a CLA? |
/cc @Eilon |
@vlesierse Thanks for trying out 👍 |
@davidfowl Surely I did using DocuSign. |
CLA for @muojp is confirmed. |
# Install libuv for Kestrel from source code (binary is not in wheezy and one in jessie is still too old) | ||
RUN apt-get -qqy install autoconf automake build-essential libtool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider multilining and alphabetising: as per https://docs.docker.com/articles/dockerfile_best-practices/#sort-multi-line-arguments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@friism thanks for pointing out. I updated the PR for sure.
Add build of libuv for supporting Kestrel Web Server
As Kestrel is supposed to be the major web server backend on ASP.NET for Linux, I wanted to give it a try. So, I added build procedure of libuv to satisfy the dependency.
I created and tested my PR against 1.0.0-beta1.
tested automated build on my fork at Docker Hub: https://registry.hub.docker.com/u/muojp/aspnet-docker/builds_history/82573/ and also tested on derived https://registry.hub.docker.com/u/muojp/hellovnext-docker/ for making sure everything works fine.
For double checking, please try this:
(Note: I've already signed CLA)