Skip to content
This repository has been archived by the owner on May 31, 2019. It is now read-only.

Add build of libuv for supporting Kestrel Web Server #8

Merged
merged 1 commit into from
Nov 16, 2014

Conversation

muojp
Copy link
Contributor

@muojp muojp commented Nov 15, 2014

As Kestrel is supposed to be the major web server backend on ASP.NET for Linux, I wanted to give it a try. So, I added build procedure of libuv to satisfy the dependency.

I created and tested my PR against 1.0.0-beta1.
tested automated build on my fork at Docker Hub: https://registry.hub.docker.com/u/muojp/aspnet-docker/builds_history/82573/ and also tested on derived https://registry.hub.docker.com/u/muojp/hellovnext-docker/ for making sure everything works fine.

For double checking, please try this:

$ docker run -p 5000:5000 -di muojp/hellovnext-docker:latest /bin/bash -c "kpm restore && k web"
$ ab -k -n 100 -c 20 http://localhost:5000/
-> ok
$ docker run -p 5000:5000 -di muojp/hellovnext-docker:latest /bin/bash -c "kpm restore && k kestrel"
$ ab -k -n 100 -c 20 http://localhost:5000/
-> ok

(Note: I've already signed CLA)

@aminjam
Copy link

aminjam commented Nov 15, 2014

+1 for merge. Thanks for the Kestrel Support. It worked for me.

@muojp
Copy link
Contributor Author

muojp commented Nov 15, 2014

@aminjam thanks for trying!

@muojp muojp mentioned this pull request Nov 15, 2014
@ahmetb
Copy link
Contributor

ahmetb commented Nov 15, 2014

@muojp great work here, thanks! I confirmed it enables k kestrel on

  • aspnet/Home/samples/HelloWeb,
  • aspnet/Home/samples/HelloMvc, and
  • @davidfowl's HelloWorldVNext/helloworldweb

samples while running inside docker containers. @muojp can you indent lines 15-19 in dockerfiles with one tab to stay consistent with the rest of the file?

LGTM! :shipit:

cc: @davidfowl to merge once he's happy.

@muojp
Copy link
Contributor Author

muojp commented Nov 15, 2014

@ahmetalpbalkan thanks for trying out and pointing out indent mismatch. I fixed indent (spaces -> tab), squashed changes and force pushed 🍰

@vlesierse
Copy link
Contributor

Great work! It works for me as well even with my onbuild scenario.

+1 for merge 👍

@davidfowl
Copy link
Member

@muojp Did you fill out a CLA?

@davidfowl
Copy link
Member

/cc @Eilon

@muojp
Copy link
Contributor Author

muojp commented Nov 15, 2014

@vlesierse Thanks for trying out 👍

@muojp
Copy link
Contributor Author

muojp commented Nov 15, 2014

@davidfowl Surely I did using DocuSign.

@Eilon
Copy link
Member

Eilon commented Nov 16, 2014

CLA for @muojp is confirmed.

# Install libuv for Kestrel from source code (binary is not in wheezy and one in jessie is still too old)
RUN apt-get -qqy install autoconf automake build-essential libtool
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@friism thanks for pointing out. I updated the PR for sure.

@friism friism mentioned this pull request Nov 16, 2014
davidfowl added a commit that referenced this pull request Nov 16, 2014
Add build of libuv for supporting Kestrel Web Server
@davidfowl davidfowl merged commit 5f65e31 into aspnet:master Nov 16, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants