Skip to content
This repository has been archived by the owner on Dec 18, 2017. It is now read-only.

In project.json source, ignore, preprocess etc should be arrays #133

Closed
victorhurdugaci opened this issue Apr 28, 2014 · 0 comments
Closed

Comments

@victorhurdugaci
Copy link
Contributor

Is there any particular reason why we use semicolon separated values in project.json instead of json arrays?

Today:

{
  "code":"Program1.cs;Program2.cs",
  "exclude":"Ignore1.cs;Ignore2.cs",
  "dependencies" : {
   },
   "configurations":  {
     "net45" : {},
     "k10": {
       "dependencies": {
         "System.Runtime": "4.0.20.0",
         "System.Console": "4.0.0.0"
       }
     }
   }
 }

Why not?

{
  "code":["Program1.cs","Program2.cs"],
  "exclude":["Ignore1.cs","Ignore2.cs"],
  "dependencies" : {
   },
   "configurations":  {
     "net45" : {},
     "k10": {
       "dependencies": {
         "System.Runtime": "4.0.20.0",
         "System.Console": "4.0.0.0"
       }
     }
   }
 }

Keys that should use arrays:

  • code
  • exclude
  • preprocess
  • shared
  • resources (?)
@davidfowl davidfowl added 0 - Backlog and removed bug labels May 26, 2014
@davidfowl davidfowl added this to the CTP2 milestone May 26, 2014
@davidfowl davidfowl self-assigned this May 26, 2014
davidfowl added a commit that referenced this issue May 26, 2014
- Allow arrays and strings
- Allow ';' within array elements
- Added unit tests
- Made klr.cmd work again for incremental builds

#133
@glennc glennc closed this as completed May 27, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants