You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 18, 2017. It is now read-only.
Currently we mix different aliases of types across the code e.g. WCHAR*, LPWSTR, LPTSTR are used all over the place (e.g. bool GetTrustedPlatformAssembliesList(WCHAR* szDirectory, bool bNative, LPWSTR pszTrustedPlatformAssemblies, size_t cchTrustedPlatformAssemblies))
even though they are basically the same type.
Similarly we mix usage of _T and L macros and also mix string functions like _tcs* and wcs* and _tprintf_s vs. wprintf_s
We should just use one alias or ideally - switch to STL and not use them at all.
We could consider creating our own alias for std::string and std::wstring (like dnx::string_t) type that would be used across the codebase regardless of what platform we are using.
The text was updated successfully, but these errors were encountered:
@davidfowl - yes. Most of the occurrences are being fixed in #2263 which has not been merged yet. I will need to do a final sweep after #2263 is merged since fixing this was not the main goal there.
Currently we mix different aliases of types across the code e.g.
WCHAR*
,LPWSTR
,LPTSTR
are used all over the place (e.g. bool GetTrustedPlatformAssembliesList(WCHAR* szDirectory, bool bNative, LPWSTR pszTrustedPlatformAssemblies, size_t cchTrustedPlatformAssemblies))even though they are basically the same type.
Similarly we mix usage of
_T
andL
macros and also mix string functions like_tcs*
andwcs*
and_tprintf_s
vs.wprintf_s
We should just use one alias or ideally - switch to STL and not use them at all.
We could consider creating our own alias for
std::string
andstd::wstring
(like dnx::string_t) type that would be used across the codebase regardless of what platform we are using.The text was updated successfully, but these errors were encountered: