Skip to content
This repository has been archived by the owner on Dec 18, 2017. It is now read-only.

Implicit DNX min version check #2197

Closed
muratg opened this issue Jul 7, 2015 · 9 comments
Closed

Implicit DNX min version check #2197

muratg opened this issue Jul 7, 2015 · 9 comments

Comments

@muratg
Copy link
Contributor

muratg commented Jul 7, 2015

If any of the packages in project.json depend on a particular DNX and this is not less than the DNX version we're currently using, we can detect and throw on the app start. This would prevent some of the issues described in this bug: dotnet/aspnetcore#312 (comment)

@muratg muratg added this to the 1.0.0-beta7 milestone Jul 7, 2015
@davidfowl
Copy link
Member

@muratg I think we need to do this for beta6

@victorhurdugaci victorhurdugaci self-assigned this Jul 14, 2015
@muratg
Copy link
Contributor Author

muratg commented Jul 14, 2015

@victorhurdugaci has found a potential issue that we'll need to discuss. Tentatively putting in beta 6.

@muratg muratg closed this as completed Jul 14, 2015
@muratg muratg modified the milestones: 1.0.0-beta6, 1.0.0-beta7 Jul 14, 2015
@davidfowl davidfowl reopened this Aug 5, 2015
@davidfowl
Copy link
Member

Reopening this /cc @muratg @glennc

@davidfowl davidfowl removed this from the 1.0.0-beta6 milestone Aug 5, 2015
@analogrelay
Copy link
Contributor

/cc @avanderhoorn (I think this is what you were talking about ;)). Only covers one direction (packages later than runtime) though.

@avanderhoorn
Copy link
Member

@anurse thanks, better than nothing!

@glennc glennc added this to the 1.0.0-beta8 milestone Aug 11, 2015
@victorhurdugaci
Copy link
Contributor

  • Check for the version of Abstractions
  • If the app tries to load a newer one, stop it

@muratg
Copy link
Contributor Author

muratg commented Sep 4, 2015

Does this have open design questions? @victorhurdugaci, can we remove the needs design label?

@analogrelay
Copy link
Contributor

technically we keep that label but put design:done on it. /cc @glennc we still using your app?

@victorhurdugaci
Copy link
Contributor

Note: this will be interesting to see in the wild because our dev bits have a higher version than release ones (1.0.0-beta7-123 > 1.0.0-beta7)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants