Skip to content
This repository has been archived by the owner on Dec 18, 2017. It is now read-only.

The project.json beta5/beta6 schemas are missing properties from beta4 #2342

Closed
wholroyd opened this issue Jul 25, 2015 · 8 comments
Closed

Comments

@wholroyd
Copy link

According to #45, it appeared that at one point the project.json file wouldn't do anything that the .nuspec file did. About a year later in #1302 it seems there was a change in heart and those NuSpec properties were added in.

It looks like they are defined in the beta4 schema, but have since been removed in the beta5 and beta6 schemas.

Was there another change of heart in this decision and it just hasn't been removed from the code, or did the schema somehow regress?

@davidfowl
Copy link
Member

Everything possible in the nuspec should be possible in project.json. It is indeed a replacement when dealing with dnx/xproj projects.

@wholroyd
Copy link
Author

I'll submit a PR over in SchemaStore to fix the beta5 and beta6 file because they're missing.

@davidfowl
Copy link
Member

Thanks!

@wholroyd
Copy link
Author

Why is the Id property from the NuSpec not used? Should it be?

One of the issues I'm having is trying to get the DNX packaging to produce a NuSpec with the proper ID set in it. It's supposed to take it from project.Name, but if the name is dotted, it somehow only uses the last octect. For example, if the project is something like Company.Group.Library it comes out as Library in the NuSpec.

So how do I keep library name continuity from *.nuspec to the newer project.json method?

@Eilon
Copy link
Member

Eilon commented Jul 27, 2015

I'm guessing it's using the folder name and not the id. I believe there's a bug somewhere in this repro to allow the folder name to be different from the package id.

@Eilon
Copy link
Member

Eilon commented Jul 27, 2015

I think I'm thinking of #2312, but perhaps that's a slightly different issue...

@wholroyd
Copy link
Author

You're right on the folder name, quick search and found this comment not matching up with following code.

https://github.com/aspnet/dnx/blob/master/src/Microsoft.Framework.Runtime/Project.cs#L139-L140

But then we'd have the project name to set by id or name property by line 147.

@wholroyd
Copy link
Author

I think the original issues I wanted to cover are now complete, closing issue. Thank you @Eilon and @davidfowl

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants