Skip to content
This repository has been archived by the owner on Dec 18, 2017. It is now read-only.

Add attributes from .nuspec to project.json schema #1302

Closed
conniey opened this issue Feb 28, 2015 · 8 comments
Closed

Add attributes from .nuspec to project.json schema #1302

conniey opened this issue Feb 28, 2015 · 8 comments

Comments

@conniey
Copy link

conniey commented Feb 28, 2015

project.json seems to unify (packages.config, *.nuspec and dependencies in *.csproj). But, it is lacking some .nuspec attributes that may be useful to enterprise developers.

I am developing a library using ASP.NET vNext but it is a hassle to automate the signing/upload of this package because I have to unzip it, add signed dlls, and re-write the .nuspec with a template.

Useful Attributes:

  • requireLicenseAcceptance: It does not allow you to add a license agreement. By default, when it generates a package, it sets this attribute to false.
  • licenseUrl
  • copyright
  • projectUrl
  • tags: It'd be nice to be able to search for my package with some keywords.
@davidfowl
Copy link
Member

We're missing licenseUrl and copyright but the rest are available.

https://github.com/aspnet/XRE/blob/dev/src/Microsoft.Framework.PackageManager/Building/BuildManager.cs#L244

We need to update the project.json schema.

/cc @madskristensen @ChengTian

@Daniel15
Copy link

Icon appears to be missing as well.

It would be nice to have a way to set the title too. Currently it just sets it to the "raw" name but I usually set a friendly name in my NuGet packages (eg. ID = "React.Web.Mvc4", Name = "ReactJS.NET (MVC 4 and 5)")

@davidfowl
Copy link
Member

I'm not a fan of title but I understand that people do use it.

@davidfowl
Copy link
Member

@conniey I also assume that by signing, you mean strong naming?

@conniey
Copy link
Author

conniey commented Feb 28, 2015

@davidfowl Authenticode and strong name signing. Issue #621 seems to cover the authenticode scenario. Do you have any plans on adding StrongName signing?

@davidfowl
Copy link
Member

We currently have plans to strong name everything by default with a key that cannot be configured. This is mostly to support scenarios where people need to interop with desktop as our CoreCLR loader ignores strong naming.

@StefH
Copy link

StefH commented Mar 5, 2015

The owners property is also not supported. Currently the value from authors is copied into this field when the nuget package is created.

Other non-supported fields are:
summary
releaseNotes

@davidfowl
Copy link
Member

This is all done in beta4. ReleaseNotes haven't been added because it's weird 😄

@davidfowl davidfowl added this to the 1.0.0-beta4 milestone Mar 29, 2015
@davidfowl davidfowl self-assigned this Mar 29, 2015
Shazwazza added a commit to Shazwazza/Docs that referenced this issue Sep 21, 2015
The standard Nuspec properties are now part of the project.json which are used to build the nuget package output. See: aspnet/dnx#1302
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants