Skip strong name signing on Mono until Roslyn supports it

[akoeplinger]

Building projects that specify a keyFile in project.json (like serilog) doesn't work on Mono currently since the following error is generated:

error CS7027: Error signing output with public key from file '../../assets/Serilog.snk' -- Assembly signing not supported.

Since signing isn't supported by Roslyn on non-Windows platforms yet, signing should just be skipped and a warning printed instead.

[moozzyk]

On Mono you should be able to sign with OSS Sigining by using "strongName" : true instead of `"keyFile" : ...".

[akoeplinger]

@moozzyk that doesn't help me for projects which I don't control 😄

[akoeplinger]

To be clear, I can just remove the keyFile from project.json and it builds fine, but that is annoying and means a subpar out of the box experience when working with community projects on Mono.

[moozzyk]

@akoeplinger - I wonder why not commit a change to the project and change the signing to OSS? If the snk is distributed with the project then I think there is not much difference between this and OSS signing. If snk is not distributed with the project you would not be able to compile anyways.

[davidfowl]

@moozzyk the only valid reason would be because of it being a breaking change.

[moozzyk]

@davidfowl Yeah, you're right. How about falling back to OSS signing + warning if the platform does not support snk?

[akoeplinger]

That sounds OK to me as well.

[glennc]

@moozzyk Would you be likely to fit this into beta8 or should we assign it to the next milestone?

[borgdylan]

Will this be done specifically for roslyn? Compilers based on IKVM.Reflection should not have issues signing with an SNK on mono. So the decision of not supporting SNK on mono should be the compiler's decision.

[davidfowl]

This issue is about the roslyn compiler.

[Illeris]

Same issue on Windows, providing a ".snk" file in WithCryptoKeyFile:

CSharpCompilationOptions compilationOptions = new CSharpCompilationOptions(Microsoft.CodeAnalysis.OutputKind.DynamicallyLinkedLibrary).WithCryptoKeyFile(String.IsNullOrEmpty(ca.AssemblySigningFile) ? null : ca.AssemblySigningFile);

[davidfowl]

@Illeris what?