Skip to content
This repository has been archived by the owner on Dec 18, 2017. It is now read-only.

Add frameworkAssemblies node to project.json to add gac/reference assemblies #640

Closed
davidfowl opened this issue Sep 17, 2014 · 2 comments
Closed
Assignees
Milestone

Comments

@davidfowl
Copy link
Member

Today we mix these in the same section which causes several issues including #619. We're going to separate these out into a new section (consistent with the nuspec):

{
  "frameworks": {
    "net45": {
      "frameworkAssemblies": {
        "System.Xml": "4.0.0.0"
      }
    }
  }
}

These won't be restored using kpm restore and they'll be put in the frameworkAssemblies section when generating the nupkg.

@davidfowl davidfowl added this to the 1.0.0-beta1 milestone Sep 17, 2014
@davidfowl davidfowl self-assigned this Sep 17, 2014
davidfowl added a commit that referenced this issue Sep 25, 2014
- The frameworkAssemblies section is specific to a target framework
- Refactored BuildContext to call into the ProjectReferenceDependencyProvider.
This means that only a single place actually uses the project class directly
(which is nice).
- GetLibraryDescription now takes a Library instead of name and version
(we may need to revisit this and create a different poco). When @lodejard finishes
dependency types we'll see how this ends up
- Preserve the backwards compatibility of declaring frameworkAssemblies in
dependencies temporarily
- Added tests for parsing frameworkAssemblies

#640
#619
@Praburaj
Copy link
Contributor

Praburaj commented Oct 2, 2014

@davidfowl @ChengTian I added something like this to my project.json

"frameworks": {
        "aspnet50": {
            "frameworkAssemblies": {
                "System.Xml": "4.0.0.0",
                "System.Data": "4.0.0.0"
            }
        }
    }

While doing a kpm restore i see this error. Should the version be still "" or it is an actual GAC assembly version?

Resolving complete, 7927ms elapsed
Unable to locate System.Xml >= 4.0.0.0
Unable to locate System.Data >= 4.0.0.0
Installing Microsoft.AspNet.SignalR.Client 2.1.1
Installing Newtonsoft.Json 5.0.1
Installing Xunit.KRunner 1.0.0-beta1-10371
Installing Microsoft.Framework.TestAdapter 1.0.0
Installing xunit.execution 2.0.0-aspnet-alpha4-10007
Installing xunit.core 2.0.0-aspnet-alpha4-10007
Installing xunit.abstractions 2.0.0-aspnet-alpha4-10007
Installing xunit.assert 2.0.0-aspnet-alpha4-10007
Restore complete, 8526ms elapsed

@davidfowl
Copy link
Member Author

Looks like a bug somewhere. I'll take a look

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants