Update the priority of finding matchs among walk providers #1000
Conversation
|
For following case: The kpm won't hit http if all the packages are found under |
| @@ -28,6 +25,7 @@ public interface IWalkProvider | |||
| Task<WalkProviderMatch> FindLibraryBySnapshot(Library library, FrameworkName targetFramework); | |||
| Task<IEnumerable<LibraryDependency>> GetDependencies(WalkProviderMatch match, FrameworkName targetFramework); | |||
| Task CopyToAsync(WalkProviderMatch match, Stream stream); | |||
| bool Express { get; } | |||
There was a problem hiding this comment.
Help me find a better mean? Essentially it means this provider is faster so should be try first.
There was a problem hiding this comment.
Express is a bad name. Order?
There was a problem hiding this comment.
IsLocal? Say what it is, not how someone will consume it.
There was a problem hiding this comment.
Yes, maybe IsLocal or IsHttp (and do the negation)
There was a problem hiding this comment.
Ok, let's go with IsLocal.
|
Fix the typo in your commit message |
|
Yup. |
|
@loudej ⌚ |
|
Lets do IsHttp the term local is overused |
|
aye aye, sir. |
troydai
force-pushed
the
update.kpmrestore
branch
from
5486913
to
df5fe9e
Compare
|
Rebased. |
| @@ -37,8 +35,11 @@ public class LocalWalkProvider : IWalkProvider | |||
| public LocalWalkProvider(IDependencyProvider dependencyProvider) | |||
| { | |||
| _dependencyProvider = dependencyProvider; | |||
| IsHttp = false; | |||
There was a problem hiding this comment.
Don't need this, it's the default value.
|
Ship it |
Break the remote sources into two groups. The group of the http based sources won't be executed unless the group of the local sources can't produce a match. Among the same group all the sources are still executed parallel.
troydai
force-pushed
the
update.kpmrestore
branch
from
a934556
to
17de54d
Compare
|
Rebased and squashed. |
Break the walk providers into to group. The groups use a local file system
based source take the priority.
#999