This repository has been archived by the owner on Dec 18, 2017. It is now read-only.
Added ProjectFormatException and more detailed errors to DTH #1065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ProjectFormatException has the project path, line and Column (1 based), where the exception ocurred in the project.json file. - Give more specific errors when they aren't just JsonReaderExceptions, but semantic exceptions within the project format itself (beyond just JSON). - Added Path, Line and Column to ErrorMessage in DTH #1052
| throw new InvalidDataException("Unable to resolve dependency ''."); | ||
|
|
||
| throw ProjectFormatException.Create( | ||
| "Unable to resolve dependency ''.", |
There was a problem hiding this comment.
Kind of a crappy error. Should it say like "empty dependency" or something?
There was a problem hiding this comment.
Or say that the dependency isn't specified? Or that dependency names can't be empty?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(1 based), where the exception ocurred in the project.json file.
but semantic exceptions within the project format itself (beyond just JSON).
Specify the ErrorSource, LineNumber and Column number when errors occur in DTH #1052
/cc @BillHiebert