This repository has been archived by the owner on Dec 18, 2017. It is now read-only.
Add compileBuiltIn property to project.json #1289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
@glennc @victorhurdugaci @lodejard @ChengTian |
| string projectFilePath, | ||
| string name, | ||
| string legacyName, | ||
| IEnumerable<string> fallbackIncludeing = null, |
There was a problem hiding this comment.
typo in fallbackIncludeing
|
This shouldn't break people that respecify the pattern today right? |
|
Respecify pattern won't break the application. Tested all projects in universe. And the internally the duplicate the patterns will be removed. But there is possibility that it will breaks in one situation that is when user explicitly overwrite But the chance is low. |
|
@davidfowl sign off? Ping |
| @@ -88,6 +89,20 @@ public void FilesPatternsAreSet() | |||
| Assert.Equal(new string[] { "buggy/*.*", "bin/**", "obj/**", "**/*.kproj", "no_pack/*.*" }, target.ContentPatternsGroup.ExcludePatterns); | |||
| } | |||
|
|
|||
| [Fact] | |||
| public void RewriteCompileBuiltIn() | |||
There was a problem hiding this comment.
Add a test that does:
{
"compile": ["**/*.cs"]
}
|
Two tests added. |
|
Ping |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1288