Add DTH Plugin Registration recovery. #1413
Conversation
|
Hi @NTaylorMullen, I'm your friendly neighborhood Microsoft Open Technologies, Inc. Pull Request Bot (You can call me MSOTBOT). Thanks for your contribution!
TTYL, MSOTBOT; |
ghost
added
the
|
/cc @davidfowl @ToddGrun |
| _filesChanged.WasAssigned || | ||
| _rebuild.WasAssigned || | ||
| _restoreComplete.WasAssigned || | ||
| _sourceTextChanged.WasAssigned) |
There was a problem hiding this comment.
Do you need to actually do something for all of these types of messages? That doesn't seem right. You only need to do work if there is a plugin registered.
There was a problem hiding this comment.
I can expose a WorkNeeded property on the PluginHandler to short-circuit all of this. I just figured the extra checking here was pretty quick and the Process method basically no-ops if there's nothing to do.
There was a problem hiding this comment.
I'm not worried about the verbosity of the if statement. I'm not sure this is correct. No work should happen if a plugin is never registered.
|
Updated. |
| (_filesChanged.WasAssigned || | ||
| _rebuild.WasAssigned || | ||
| _restoreComplete.WasAssigned || | ||
| _sourceTextChanged.WasAssigned)); |
NTaylorMullen
force-pushed
the
nimullen/dthpluginrecovery.1405
branch
from
f5bce79
to
33d986f
Compare
|
Updated. |
NTaylorMullen
force-pushed
the
nimullen/dthpluginrecovery.1405
branch
from
33d986f
to
15386f5
Compare
|
Updated. Did not make |
|
Good? |
|
Getting this in tonight unless there's an objection 😄 |
- Involved updating the DesignTimeHost.Interface bits to accept IAssemblyLoadContext in a plugins ProcessMessages method. - Added response messages to register/unregister for successful/unsuccessful results. - Removed concurrency protection bits from PluginHandler since it's overkill. - Added a Plugin section to ApplicationContext. #1405
NTaylorMullen
force-pushed
the
nimullen/dthpluginrecovery.1405
branch
from
ee021cf
to
a8ad362
Compare
Enable DTH plugins to recover. #1405