This repository has been archived by the owner on Dec 18, 2017. It is now read-only.
DTH applies out-of-date lock file to reduce error messages #1465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Did you test cases where there were dramatic changes to the dependencies? |
|
Yes, I deleted all dependencies of a starter web app and added them back |
|
Made code review changes |
|
|
ChengTian
force-pushed
the
wei/DTH-reduces-errors-on-out-of-date-lockfile
branch
from
a182c47
to
7ea973d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parent #1444
@davidfowl , this is the most simple way to fix #1444. Tested with starter web app, when you add a new dependency
XYZ.1.0.0toproject.jsonand Ctrl+S, the error list only showsXYZ.1.0.0 cannot be resolved