This repository has been archived by the owner on Dec 18, 2017. It is now read-only.
Make sure lock file and global install project are not readonly #1850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @ChengTian |
|
|
| // Make sure that if the lock file exists, it is not readonly | ||
| if (File.Exists(filePath)) | ||
| { | ||
| FileAttributes attributes = File.GetAttributes(filePath); |
There was a problem hiding this comment.
Any reason this code is duplicated?
There was a problem hiding this comment.
Also can't this fail sometimes? Can it ever fail?
There was a problem hiding this comment.
It can fail if you don't have permissions but we should let it fail. Let the callers decide if they want to handle the exception or not. In the two cases in which we use it, we want it to fail because there is nothing we can do if we cannot remove the readonly attribute
|
|
victorhurdugaci
force-pushed
the
victorhu/readonly
branch
from
20e6a62
to
34eaf00
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1612
cc @davidfowl