This repository has been archived by the owner on Dec 18, 2017. It is now read-only.
"dnu restore" checks corrupted packages #2232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -6,6 +6,7 @@ | |||
| using Microsoft.Framework.CommonTestUtils; | |||
| using Microsoft.Framework.PackageManager.FunctionalTests; | |||
| using Xunit; | |||
| using NuGet; | |||
|
Thanks for the feedback. Fixed in the latest commit. |
| @@ -108,6 +108,14 @@ public IEnumerable<PackageInfo> FindPackagesById(string packageId) | |||
| continue; | |||
| } | |||
|
|
|||
| var manifestFilePath = _repositoryRoot.GetFiles(versionDir, "*" + Constants.ManifestExtension) | |||
There was a problem hiding this comment.
Do we really need this check at runtime?
There was a problem hiding this comment.
After introducing lock file, this logic is never executed during runtime of your apps. It only happens during dnu restore.
|
|
ChengTian
force-pushed
the
wei/dnu-restore-check-corrupted-packages
branch
from
a651321
to
303264e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parent #1243
Without this change, when
{id}.nuspecis missing,dnu restorefails instead of reinstalling.@davidfowl
@BrennanConroy (I modified some of your tests)