This repository has been archived by the owner on Dec 18, 2017. It is now read-only.
Enabling implicit appbase (dnx . run -> dnx run) on Mono
#2269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Same caveat as in #2263 - for backwards compatibility it allows specifying path to a folder (or '.'). |
| var appbaseIndex = arguments.ToList().FindIndex(arg => | ||
| string.Equals(arg, "--appbase", StringComparison.OrdinalIgnoreCase)); | ||
| if (appbaseIndex >= 0 && (appbaseIndex < arguments.Length - 1)) | ||
| int parameter_idx = FindAppBaseOrNonHostOption(arguments); |
moozzyk
force-pushed
the
pawelka/appbase_mono
branch
2 times, most recently
from
9eca0d1
to
398e6bc
Compare
|
Removed checking if directory exists - now we only support |
| var appbaseIndex = arguments.ToList().FindIndex(arg => | ||
| string.Equals(arg, "--appbase", StringComparison.OrdinalIgnoreCase)); | ||
| if (appbaseIndex >= 0 && (appbaseIndex < arguments.Length - 1)) | ||
| int parameterIdx = FindAppBaseOrNonHostOption(arguments); |
moozzyk
force-pushed
the
pawelka/appbase_mono
branch
2 times, most recently
from
70e6b6b
to
ff4d263
Compare
|
⌚ |
| { | ||
| for (var i = 0; i < arguments.Length; i++) | ||
| { | ||
| if (string.Equals(arguments[i], "--appbase", StringComparison.OrdinalIgnoreCase)) |
There was a problem hiding this comment.
It seems that in CommandUtil the options names are compared in case sensitive way.
https://github.com/aspnet/dnx/blob/dev/src/Microsoft.Framework.CommandLineUtils.Sources/CommandLine/CommandLineApplication.cs#L125
There was a problem hiding this comment.
I am keeping the behavior we had before: https://github.com/aspnet/dnx/pull/2269/files#diff-71b95628dab21cdd062a2d2518c8ac05L81
@davidfowl should the option names be case sensitive? (dnx.exe does the same case insensitive check)
There was a problem hiding this comment.
Let's keep the current behavior for now.
moozzyk
force-pushed
the
pawelka/appbase_mono
branch
from
ff4d263
to
24965ea
Compare
added 2 commits
July 22, 2015 07:07
Before providing appbase folder was necessary. Now we don't expect a folder anymore but assume that the current folder is the appbase folder. The only exception is where for backwards compatibility we continue to recognize `.` (so `dnx . run` continues to work). If the user really wants to provide a folder that is not the current folder they need to use the --appbase parameter. Fixes #1403
The user no longer has to provide folder (or `.`) when running dnx commands. Note that there might be an ambiguity between a folder and command which is resolved by checking if a folder with the provided name physically exists and if it does the parameter is treated as folder path otherwise it is treated as a command. Fixes #1403
moozzyk
force-pushed
the
pawelka/appbase_mono
branch
from
24965ea
to
d901b0a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user no longer has to provide folder (or
.) when running dnx commands.Note that there might be an ambiguity between a folder and command which is resolved by checking if a folder with the provided name physically exists and if it does the parameter is treated as folder path otherwise it is treated as a command.
Fixes #1403