This repository has been archived by the owner on Dec 18, 2017. It is now read-only.
Add version to ILibraryInformation #709
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -11,6 +11,7 @@ public sealed class LibraryInformation : ILibraryInformation | |||
| public LibraryInformation(LibraryDescription description) | |||
| { | |||
| Name = description.Identity.Name; | |||
| Version = description.Identity.Version.ToString(); | |||
There was a problem hiding this comment.
Need to add any null checks? Looking at the codes I don't see any guarantees about these being non-null.
There was a problem hiding this comment.
It should never be null at this point.
There was a problem hiding this comment.
Should? 😄 Would it make sense to enforce that requirement throughout the data structures?
There was a problem hiding this comment.
Yea but c# doesn't have a type system I can use to represent that.
There was a problem hiding this comment.
Constructors that throw if there's a null param?
|
Cool! You tamed the beast! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#666 the mark of the beast...
/cc @victorhurdugaci