This repository has been archived by the owner on Dec 18, 2017. It is now read-only.
Auto glob folder patterns in project.json #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| project.SharedPatterns = GetSourcePattern(rawProject, "shared", _defaultSharedPatterns); | ||
| project.ResourcesPatterns = GetSourcePattern(rawProject, "resources", _defaultResourcesPatterns); | ||
| project.ContentsPatterns = GetSourcePattern(rawProject, "files", _defaultContentsPatterns); | ||
| project.SourcePatterns = GetSourcePattern(rawProject, "code", _defaultSourcePatterns) |
There was a problem hiding this comment.
Instead of changing this code, I would make the implementation of GetSourcePattern do the right thing:
private IEnumerable<string> GetSourcePattern(Project project, JObject rawProject, string propertyName, string[] defaultPatterns)
{
return GetSourcePatternCore(rawProject, propertyName, defaultPatterns).Select(p => FolderToPattern(p, project.ProjectDirectory));
}
|
I think these tests are doing too much and we need tests for individual scenarios. |
|
Thanks for the feedbacks. Please check the follow-up commits. |
| project.ContentsPatterns = GetSourcePattern(project, rawProject, "files", _defaultContentsPatterns); | ||
|
|
||
| // 'webroot' should be excluded from compilation if specified | ||
| if (!string.IsNullOrEmpty(project.WebRoot)) |
There was a problem hiding this comment.
Remove this logic completely, it's not part of the bug.
|
|
| } | ||
| } | ||
|
|
||
| [Theory, MemberData("KrePaths")] |
There was a problem hiding this comment.
We don't usually use this pattern for attributes:
[Theory]
[MemberData("KrePaths")]
|
|
ChengTian
force-pushed
the
auto-glob-folder-patterns-in-project.json
branch
from
7eb3a50
to
fc75f6b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parent #670
Supplement to #727