This repository has been archived by the owner on Dec 18, 2017. It is now read-only.
"kpm pack" generates web.config #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return package == null ? string.Empty : package.Library.Version.ToString(); | ||
| } | ||
|
|
||
| private static string GetRuntimeFlavor(PackRuntime runtime) |
There was a problem hiding this comment.
For some of these parsing routines, can you add a comment that gives an example of what the expected inputs and outputs are?
|
The code review updates look good. Need @davidfowl , @glennc , and @GrabYourPitchforks to confirm the behavior (I'm not sure exactly what's expected). |
|
|
ChengTian
force-pushed
the
kpm-pack-generate-web.config
branch
from
d30cb20
to
2ef1d11
Compare
ChengTian
force-pushed
the
kpm-pack-generate-web.config
branch
from
2ef1d11
to
9f8fff9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parent #677