Skip to content
This repository has been archived by the owner on Dec 18, 2017. It is now read-only.

Add pointers to wrapped csprojs in wrapper project.json #916

Merged
merged 2 commits into from
Nov 21, 2014
Merged

Add pointers to wrapped csprojs in wrapper project.json #916

merged 2 commits into from
Nov 21, 2014

Conversation

ChengTian
Copy link
Contributor

parent #906

@ChengTian
Copy link
Contributor Author

Here is an example of generated project.json:

{
  "version": "1.0.0-*",
  "frameworks": {
    "net40": {
      "wrappedProject": "../../ClassLibrary1/ClassLibrary1.Net40.csproj",
      "bin": {
        "assembly": "../../ClassLibrary1/obj/debug/ClassLibrary1.dll",
        "pdb": "../../ClassLibrary1/obj/debug/ClassLibrary1.pdb"
      }
    },
    "net45+win+wpa81+wp80": {
      "wrappedProject": "../../ClassLibrary1/ClassLibrary1.PCL.csproj",
      "bin": {
        "assembly": "../../ClassLibrary1/obj/debug/ClassLibrary1.dll",
        "pdb": "../../ClassLibrary1/obj/debug/ClassLibrary1.pdb"
      }
    }
  }
}

ChengTian
ChengTian reviewed Nov 21, 2014
View reviewed changes
src/Microsoft.Framework.PackageManager/Commands/WrapCommand.cs
{
var frameworksObj = GetOrAddJObject(projectJson, "frameworks");
var targetFrameworkObj = GetOrAddJObject(frameworksObj, GetShortFrameworkName(targetFramework));
targetFrameworkObj["wrappedProject"] = relativeCsProjectPath;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should use SetPropertyValueIfEmpty after #914 is merged in

@davidfowl
Copy link
Member

:shipit:

@ChengTian ChengTian force-pushed the add-pointers-to-csprojs-in-wrapper-project.json branch from 3b4b759 to 60494b1 Compare November 21, 2014 19:16
@ChengTian ChengTian merged commit 60494b1 into dev Nov 21, 2014
@ChengTian ChengTian deleted the add-pointers-to-csprojs-in-wrapper-project.json branch March 9, 2015 17:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ChengTian @davidfowl