This repository has been archived by the owner on Dec 18, 2017. It is now read-only.
"kpm pack" looks for web.config under wwwroot instead of project root #972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ChengTian Could you also fix MusicStore? Are there any other apps in our repos need changing because of this fix? |
So this PR is ready to go. |
- Improve functional test utilities - Add functional tests for script generation - Mark bash scripts as executable when "kpm pack" on *nix
|
|
ChengTian
force-pushed
the
kpm-pack-looks-for-web.config-source-in-wwwroot
branch
from
701e543
to
96cfceb
Compare
ChengTian
deleted the
kpm-pack-looks-for-web.config-source-in-wwwroot
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parent #962
@troydai @Praburaj , please help to review and evaluate the risk. Seems you guys worked on some web apps that need web.config. I know this will at least break MusicStore.
@davidfowl , after sign-off, I'll broadcast this change before merge it in.