optimize build, remove bower #88
Conversation
spboyer
commented
Jun 30, 2016
spboyer
commented
- Removed bower dependency in favor of npm
- Switched out rimraf package for del see - Deprecate robrich/gulp-rimraf#14
- fixed jshint issues in site.js
- added gulp build and default gulp task for clean code practices
- modified project.json to call gulp build
|
Hi @spboyer, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! The agreement was validated by .NET Foundation and real humans are currently evaluating your PR. TTYL, DNFBOT; |
|
@DamianEdwards - pulled in changes and resubmitted. |
| .pipe(csslint()) | ||
| .pipe(csslint.reporter()); | ||
| }); | ||
|
|
||
| gulp.task("lint", ["jshint", "csslint"]); | ||
| gulp.task("prepublish", ["lib", "csslint", "jshint", "min"]); |
There was a problem hiding this comment.
Why did you have to change all the dependency tasks?
There was a problem hiding this comment.
a couple reasons. First, changed to ensure to return streams where appropriate and second added dependencies to each. By doing so this makes sure that the tasks run sequentially and not in parallel.
docs -> https://github.com/gulpjs/gulp/blob/master/docs/recipes/running-tasks-in-series.md
