[0.9.1.1] bug IRepository.GetAllList() on sqlite

[dawsidious]

Hi there !

I have encoutered a regresion with 0.9.1.1.

I use GetAllList() to retrieve 160.000 records from an IRepository connected to a sqlite db.

With 0.9.1.0 and previous versions, it took 1-2 seconds.
With 0.9.1.1 it runs without any response, even after few minutes.
It never get back the list.

GetCount() method still works fine.

Tests with 0.9.1.0

var a = _pathsRepository.Count();
var b = _pathsRepository.GetAll().FirstOrDefault();
var c = _pathsRepository.GetAllList();
var d = await _pathsRepository.GetAllListAsync();

response

a = 160000
b = 1st of the list
c = List of 160000 paths (+/- 1 second)
d = List of 160000 paths (+/- 1 second)

Tests with 0.9.1.1

var a = _pathsRepository.Count();
var b = _pathsRepository.GetAll().FirstOrDefault();
var c = _pathsRepository.GetAllList();
var d = await _pathsRepository.GetAllListAsync();

response

a = 160000
b = 1st of the list
c = ... ==> infinite time; never end.
d = ... ==> infinite time; never end.

[UnitOfWork(false)] is set on my method, since sqlite require it.
It's working fine on 0.9.1.0

Any idea of a change on this release which could cause that ? :)

I reverted back to 0.9.1.0 ABP.* (no other package) and it works again.

[hikalkan]

Hi,

The only significiant change is here: v0.9.1.0...v0.9.1.1#diff-4ff9ae44e68e35ab1df34e2b9e650913R214

We added dbContext.Entry(e.Entity).State = previousState since it was causing this issue: #1042

It seems this gets time. We will test it with a big data to see the result and will make some optimization if possible, or make ObjectContext_ObjectMaterialized optional.

Thanks for informing us.

[dawsidious]

Additionnal info for testing:

• due to Entry state like you specified; this is not related to a specific db. (testing on sql server is fine)
• when I say a lot of data... Before, I used GetAllList to retrieve 16.200.000 entities (sql server) within few seconds.

--> In this case I don't need any entry state since these data are read-only for calculs.

thks for the help :)

[natiki]

FWIW I believe this regression also affects SQL Server. We have some tests that do a IRepository.GetAll() on a table that has ~215,000 records. Test was passing fine prior to upgrade to 0.9.1.1 at which point the test never seems to return the list even when left for a few minutes.

UPDATE: I have rolled back to 0.9.1.0 and the problem goes away for me as well. i.e. Calls to GetAll() including the one described above now return as expected.

[dawsidious]

yup my bad; I didn't explained clearly when I said :
•due to Entry state like you specified; this is not related to a specific db. (testing on sql server is fine)

I would said that i can reproduce the same performanc error on sql server. so yeah, it affects every db (sql server, sqlite, oracle ... :) )