Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ASP.NET Core Module's AbpResultFilter should override Cache-Control headers rather than adding it again. #1363

Closed
hikalkan opened this issue Sep 11, 2016 · 1 comment
Closed

ASP.NET Core Module's AbpResultFilter should override Cache-Control headers rather than adding it again. #1363

hikalkan opened this issue Sep 11, 2016 · 1 comment
Labels
bug

Comments

@hikalkan
Copy link
Member

hikalkan commented Sep 11, 2016 •
edited

Otherwise, get get the following exception:

System.ArgumentException: An item with the same key has already been added.
   at Microsoft.AspNetCore.Server.Kestrel.Internal.Http.FrameResponseHeaders.AddValueFast(String key, StringValues value)
   at Microsoft.AspNetCore.Server.Kestrel.Internal.Http.FrameHeaders.System.Collections.Generic.IDictionary<System.String,Microsoft.Extensions.Primitives.StringValues>.Add(String key, StringValues value)
   at Abp.AspNetCore.Mvc.Results.AbpResultFilter.SetNoCache(ResultExecutingContext context)
   at Abp.AspNetCore.Mvc.Results.AbpResultFilter.OnResultExecuting(ResultExecutingContext context)
   at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.<InvokeResultFilterAsync>d__31.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.<InvokeAllResultFiltersAsync>d__29.MoveNext()
@hikalkan hikalkan added the bug label Sep 11, 2016
@hikalkan hikalkan changed the title AbpResultFilter should override Cache-Control headers rather than adding it again. ASP.NET Core Module's AbpResultFilter should override Cache-Control headers rather than adding it again. Sep 11, 2016
@hikalkan
Copy link
Member Author

Published Abp.AspNetCore v0.12.0.1 nuget package to fix this bug: https://www.nuget.org/packages/Abp.AspNetCore

KenProDev pushed a commit to KenProDev/aspnetboilerplate that referenced this issue Jan 17, 2017
@hikalkan
Fixed aspnetboilerplate#1363: ASP.NET Core Module's AbpResultFilter s…
3a54758 
…hould override Cache-Control headers rather than adding it again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hikalkan