Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deserialization problem caused by Type in AbpCache data #4709

Open
realLiangshiwei opened this issue Jul 18, 2019 · 7 comments
Open

Deserialization problem caused by Type in AbpCache data #4709

realLiangshiwei opened this issue Jul 18, 2019 · 7 comments
Assignees
@maliming
Labels
problem
Milestone
Backlog

Comments

@realLiangshiwei
Copy link
Contributor

In the design of ABP, each cached data will have type Type information, and use type to deserialize data when getting cache.

aspnetboilerplate/src/Abp/Runtime/Caching/AbpCacheData.cs

Line 37 in 3cf5e84

private static StringBuilder SerializeType(Type type, bool withAssemblyName = true, StringBuilder typeNameBuilder = null)

But in different projects or solutions, the type of assembly is inconsistent with the namespace, which will cause deserialization exceptions.

aspnetboilerplate/src/Abp.RedisCache/Runtime/Caching/Redis/AbpRedisCache.cs

Line 36 in 3cf5e84

return objbyte.HasValue ? Deserialize(objbyte) : null;

@ryancyq
Copy link
Contributor

ryancyq commented Jul 18, 2019 •
edited by maliming
Loading

Hi @liangshiw , can you give an example of this?

@realLiangshiwei
Copy link
Contributor Author

Cache.zip

Write the cache in the Account project, read the cache in Order. You will see the error message.
This can be avoided by putting the User class in the shared project, but not all projects are suitable for the same solution. I think this is a design problem with ABP cache.

@maliming
Copy link
Member

Related: #3219

We should consider enhancing it.

@maliming maliming self-assigned this Jul 19, 2019
@ismcagdas ismcagdas added this to the v4.9 milestone Jul 19, 2019
maliming added a commit that referenced this issue Jul 19, 2019
@maliming
fix #4709 Redis no longer stores object types.
db242e8
@maliming
Copy link
Member

maliming commented Jul 23, 2019 •
edited
Loading

dev...maliming/redisWithoutType

If we remove the Type in Redis. This will be breaking change.
once updated, the previous cache will be invalid. The previous redis cache must be emptied.

Should we make compatible code for this?

@hikalkan
Copy link
Member

The previous redis cache must be emptied

The cache should be cleared on deployment. I don't know how we can do this automatically.

@maliming maliming mentioned this issue Aug 7, 2019
Closed
@ismcagdas ismcagdas modified the milestones: v4.9, v5.0 Sep 2, 2019
@ismcagdas ismcagdas modified the milestones: v5.0, v5.1 Oct 14, 2019
@ismcagdas ismcagdas modified the milestones: v5.1, v5.2 Dec 10, 2019
@ryancyq ryancyq mentioned this issue Jan 6, 2020
Merged
@ismcagdas ismcagdas modified the milestones: v5.2, v6.0 Feb 6, 2020
maliming added a commit that referenced this issue Feb 6, 2020
@maliming
Revert "fix #4709 Redis no longer stores object types."
0438f82 
This reverts commit db242e8.
@maliming maliming mentioned this issue Mar 26, 2020
Closed
@ismcagdas ismcagdas modified the milestones: v6.0, Backlog Nov 4, 2020
@LuoyeAn
Copy link

LuoyeAn commented May 6, 2021

any solution now?

@maliming
Copy link
Member

maliming commented May 7, 2021

@TingtingAn
You can use a common assembly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maliming maliming

Labels
problem
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Redis no longer stores object types. aspnetboilerplate/aspnetboilerplate
6 participants
@hikalkan @ismcagdas @ryancyq @maliming @LuoyeAn @realLiangshiwei