Fix MailMessage to MimeMessage conversion #2590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssage to MimeMessage
acjh
reviewed
Oct 12, 2017
src/Abp.MailKit/EmailExtensitons.cs
Outdated
| if (contentType.MediaType.Equals("text", StringComparison.OrdinalIgnoreCase)) | ||
| { | ||
| // Original: part = new TextPart(contentType); | ||
| // Due to consturctor of TextPart(ContentType contentType) being internal, mimic the instantiation by using MimePart(ContentType contentType) |
There was a problem hiding this comment.
constructor*- Break line after comma
src/Abp.MailKit/EmailExtensitons.cs
Outdated
| /// </summary> | ||
| /// <returns>The equivalent <see cref="MailboxAddress"/>.</returns> | ||
| /// <param name="address">The mail address.</param> | ||
| static MailboxAddress ToMailboxAddress(this MailAddress address) |
There was a problem hiding this comment.
Excess indentation (same for ToInternetAddressList)
src/Abp.MailKit/EmailExtensitons.cs
Outdated
|
|
||
| return message; | ||
| } | ||
|
|
||
| static MimePart GetMimePart(AttachmentBase item) |
There was a problem hiding this comment.
Make default private access modifier obvious (same for ToMailboxAddress and ToInternetAddressList)
|
@acjh renamed the file since it has incorrect spelling. |
acjh
reviewed
Oct 12, 2017
src/Abp.MailKit/EmailExtensions.cs
Outdated
| /// </summary> | ||
| /// <returns>The equivalent <see cref="MailboxAddress"/>.</returns> | ||
| /// <param name="address">The mail address.</param> | ||
| private static MailboxAddress ToMailboxAddress(this MailAddress address) |
There was a problem hiding this comment.
Excess indentation (same for ToInternetAddressList)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @hikalkan , as seen in #2442, I referred to the conversion method CreateFromMailMessage() and modified the
EmailExtensions.csinAbp.MailKitpackage.The current release of
MimeKit 1.18.1only supports up to Net Standard 1.3. and i think that the support for Net Standard 2.0 won't be coming so soon.