fix: the StdSchedulerFactory.GetDefaultScheduler method is not thread…

[ly303550688]

the StdSchedulerFactory.GetDefaultScheduler method is not thread safe，need lock

[acjh]

Why is it not thread-safe?

[ly303550688]

Run two unit test at the same time the, it will throw exception: Scheduler with name 'DefaultQuartzScheduler' already exists. because the AbpIntegratedTestBase class execute InitializeAbp twice

[acjh]

The test that you added passes.

[hikalkan]

@ly303550688:

Run two unit test at the same time the, it will throw exception: Scheduler with name 'DefaultQuartzScheduler' already exists. because the AbpIntegratedTestBase class execute InitializeAbp twice

Adding lock ensures that it's not called concurrently. However, it will be executed twice anyway. Isn't that a problem?

[ly303550688]

I think it's only going to happen in unit tests

[acjh]

The test that you added passes without your change.

[ly303550688]

@acjh are you sure? If I delete my change , run the test will throw exception

[ly303550688]

System.AggregateException : 发生一个或多个错误。
---- System.AggregateException : 发生一个或多个错误。
-------- Quartz.SchedulerException : Scheduler with name 'DefaultQuartzScheduler' already exists.
在 System.Threading.Tasks.Task.WaitAll(Task[] tasks, Int32 millisecondsTimeout, CancellationToken cancellationToken)
在 System.Threading.Tasks.Task.WaitAll(Task[] tasks, Int32 millisecondsTimeout)
在 System.Threading.Tasks.Task.WaitAll(Task[] tasks)
在 Abp.Quartz.Tests.AbpQuartzConfigurationTests.TestGetScheduler()
----- Inner Stack Trace -----
在 System.Threading.Tasks.Task1.GetResultCore(Boolean waitCompletionNotification) 在 Abp.Quartz.Configuration.AbpQuartzConfiguration.get_Scheduler() 在 Abp.Quartz.Tests.AbpQuartzConfigurationTests.<>c__DisplayClass0_0.<TestGetScheduler>b__1() 在 System.Threading.Tasks.Task1.InnerInvoke()
在 System.Threading.Tasks.Task.Execute()
----- Inner Stack Trace -----
在 Quartz.Impl.SchedulerRepository.Bind(IScheduler sched)
在 Quartz.Impl.StdSchedulerFactory.d__65.MoveNext()
--- 引发异常的上一位置中堆栈跟踪的末尾 ---
在 System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
在 Quartz.Impl.StdSchedulerFactory.d__65.MoveNext()
--- 引发异常的上一位置中堆栈跟踪的末尾 ---
在 System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
在 System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
在 Quartz.Impl.StdSchedulerFactory.d__69.MoveNext()

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.