Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PermissionCheckerExtensions should throw localized exceptions. #726

Conversation

liuyuanhuo
Copy link

localization for aspnetboilerplate\src\Abp\Authorization\PermissionCheckerExtensions.cs

@hikalkan hikalkan added this to the ABP v0.8.0 milestone Dec 28, 2015
@hikalkan
Copy link
Member

I did not accept it yet, because;

new LocalizableString(name, AbpConsts.LocalizationSourceName).Localize();

uses static localization helper which cause problems in unit tests.

But I added this to v0.8 milestone and try to find a good way.

Thanks a lot.

@hikalkan hikalkan modified the milestones: ABP v0.8.0, ABP v0.9.0 Jan 9, 2016
@hikalkan hikalkan self-assigned this Feb 17, 2016
@hikalkan hikalkan modified the milestones: v0.12.0, v0.10.0 Jun 30, 2016
@hikalkan hikalkan modified the milestones: v0.12.0, v1.0.0 Aug 22, 2016
@hikalkan hikalkan modified the milestones: v1.0.0, v0.13.0 Sep 10, 2016
@hikalkan hikalkan changed the title Liuyuanhuo patch abp localization PermissionCheckerExtensions should throw localized exceptions. Sep 19, 2016
@hikalkan hikalkan closed this in 550ae3a Sep 19, 2016
@abou-emish
Copy link
Contributor

abou-emish commented Sep 19, 2016

Is my issue #393 realted ?

@hikalkan
Copy link
Member

Yes, and it's fixed.

@abou-emish
Copy link
Contributor

abou-emish commented Sep 19, 2016

Thanks, don't forget to update document ;)

KenProDev pushed a commit to KenProDev/aspnetboilerplate that referenced this pull request Jan 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants