Added fix for script

asquarezone · Mar 18, 2023 · 2ad90ad · 2ad90ad
1 parent 50d0ac9
commit 2ad90ad
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/CLI/Mar23/workshop/activity1.sh b/CLI/Mar23/workshop/activity1.sh
@@ -1,5 +1,10 @@
 #!/bin/bash
 
 instanceIds=$(aws ec2 describe-instances --filters "Name=tag:Env,Values=QA" "Name=instance-state-name,Values=running" --query "Reservations[].Instances[].InstanceId" --output text)
-echo "The instance ids which will be shutdown are ${instanceIds}"
-aws ec2 stop-instances --instance-ids ${instanceIds}
+
+if [[ -n $instanceIds ]]; then
+    echo "The instance ids which will be shutdown are ${instanceIds}"
+    aws ec2 stop-instances --instance-ids ${instanceIds}
+else
+    echo "No instances found with matching criteria Env = QA"
+fi