Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

class definitions that don't inherit from another class don't need parentheses #1356

Closed
jspaaks opened this issue Mar 20, 2023 · 2 comments
Closed
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@jspaaks
Copy link

jspaaks commented Mar 20, 2023

grep -inrE "class .*\(\):"  ./asreview/**/*.py
./asreview/data/base.py:88:class ASReviewData():
./asreview/io/csv_reader.py:20:class CSVReader():
./asreview/io/csv_writer.py:15:class CSVWriter():
./asreview/io/excel_reader.py:21:class ExcelReader():
./asreview/io/excel_writer.py:15:class ExcelWriter():
./asreview/io/paper_record.py:116:class PaperRecord():
./asreview/io/ris_writer.py:19:class RISWriter():
./asreview/io/tsv_writer.py:15:class TSVWriter():
./asreview/webapp/sqlock.py:41:class SQLiteLock():
@jspaaks
Copy link
Author

jspaaks commented Mar 20, 2023

Also, classes don't need to inherit from object anymore. https://stackoverflow.com/a/45062077

@jspaaks jspaaks added help wanted Extra attention is needed good first issue Good for newcomers labels Mar 20, 2023
@J535D165
Copy link
Member

Resolved in #1404

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants