This repository has been archived by the owner on Dec 16, 2023. It is now read-only.
Support recording and serving images #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…need to be fixed.
All tests pass now, and replay can handle images
assaf
added a commit
that referenced
this pull request
Apr 18, 2014
Support recording and serving images
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found that replay wrote images correctly in fixtures/ but when serving it would mangle them.
This fix changes the reading of data from fixtures/* so that it treats data up to the 2nd \n\n as a string and after that it leaves in a raw Buffer.
All tests pass, and replay now serves images.