Skip to content
This repository has been archived by the owner on Dec 16, 2023. It is now read-only.

Added support for passing-through client cert and key #99

Merged
merged 3 commits into from Oct 19, 2017

Conversation

gzurbach
Copy link
Contributor

@gzurbach gzurbach commented May 25, 2016

I spent the last two days struggling to get a test using certificates working with node-replay.

The following snippet shows where my test was failing:

var options = {
  key: certificate.privateKey,
  cert: certificate.certificate,
  // more stuff
}

var request = https.request(options, function(response) { 
  // getting a 403 with node-replay, but 200 when running the app
});

The change in this PR allowed me to fix my test. The test runs with both node 0.10 and 4.4.

These options are listed here: https://nodejs.org/api/https.html#https_https_request_options_callback (see the last example at the bottom of the page).

Please let me know if I am using the wrong approach. Great library btw! :)

@gzurbach gzurbach mentioned this pull request May 27, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants