Do not load vanity playground if vanity is disabled.

[adymo]

This is a necessary addition to 1cdafa27d0
This way you can still run "rake db:migrate" for example even if experiment exists
and is vanity is used in the application code.

I don't quite like this solution, will appreciate any hints on how to fix this the right way.

[phillbaker]

@adymo thanks for the pull request! Darn, I thought we had this licked in #81. This looks like a repeat of #77. It would help to get a little more info about the problem you're having, how could I reproduce the bug?

It looks like we need to avoid the call here:

vanity/lib/vanity/frameworks/rails.rb

Line 10 in 6419d7e

Vanity.playground.load!

.

[adymo]

I don't have a test for this yet. I have a rails4 app that uses vanity (as a gem, loaded by bundler). The app has experiments set up. I recreated the database and ran "rake db:migrate". This failed because the initialization path goes through Vanity::Rails::load! (the code you've linked to). So it didn't matter that playground's constructor didn't connect to database. The load! should not be called at all when vanity is disabled.

[phillbaker]

Hm, yup, totally agree.

I think I'd lean toward something like:

# rails.rb
::Rails.configuration.after_initialize do
  Vanity.playground.load! if Vanity.playground.connected?
end

Thoughts? I'm curious if just short circuiting in load! could cause silent failures?

[adymo]

That looks like a better solution for me

[phillbaker]

See 056a572 and 2ce41a0. Looks like there was also a bug in not falling through on the auto-connect portion.

[adymo]

Thanks, Phill!