Merge pull request #537 from graffic/master

Use a selector in unselectOption like selectOption does.
assaf · Jun 23, 2013 · 7590588 · 7590588
2 parents eeaffb2 + 9b35599
commit 7590588
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/src/zombie/browser.coffee b/src/zombie/browser.coffee
@@ -817,10 +817,11 @@ class Browser extends EventEmitter
   #
   # Unselects an option.
   #
-  # option - option to unselect
+  # selector - selector or option to unselect
   #
   # Without callback, returns this.
-  unselectOption: (option)->
+  unselectOption: (selector)->
+    option = @query(selector)
     if option && option.getAttribute("selected")
       select = @xpath("./ancestor::select", option).iterateNext()
       unless select.multiple

diff --git a/test/forms_test.coffee b/test/forms_test.coffee
@@ -607,6 +607,18 @@ describe "Forms", ->
         selected = (!!option.getAttribute("selected") for option in browser.querySelector("#field-hobbies").options)
         assert.deepEqual selected, [true, false, false]
 
+	  describe "unselect name using option selector", ->
+      before (done)->
+        browser.visit("/forms/form")
+          .then ->
+            browser.selectOption("#hobbies-messy")
+            browser.unselectOption("#hobbies-messy")
+            return
+          .then(done, done)
+
+      it "should unselect items", ->
+        assert !browser.query("#hobbies-messy").selected
+
     describe "with callback", ->
       before (done)->
         browser.visit "/forms/form", ->