jsbin examples fail to run

[jzaefferer]

Trying to run tests from jsbin.com, which includes GA tracking code, fail with some unwieldy error output, e.g. http://jsbin.com/onomi4

Produces: https://gist.github.com/766080

The actual issue is overshadowed by the detailed console output, where it probably should just say [object Window] or something instead of printing hundreds of properties.

[boblail]

The original issue _gat is not defined seems to have been resolved.

However, visiting this site still causes at least one error:

{ stack: [Getter/Setter],
  arguments: [ 'style', undefined ],
  type: 'non_object_property_load',
  message: [Getter/Setter] } }

The cryptic 'non_object_property_load' means that code was treating either null or undefined as an object.

[boblail]

I believe the error I listed above occurs in http://jsbin.com/js/render/edit.js.

In a test that isolates ga.js (https://gist.github.com/844911), this error occurs instead:

{ stack: [Getter/Setter],
  arguments: [ 'javaEnabled', [Object] ],
  type: 'undefined_method',
  message: [Getter/Setter] } }

[boblail]

3a4cc2b addresses that one, now GA is erroring out with:

{ stack: [Getter/Setter],
  arguments: [ 'undefined' ],
  type: 'called_non_callable',
  message: [Getter/Setter] } }

[boblail]

This problem has something to do with document.write. If I replace

<script type="text/javascript">
var gaJsHost = (("https:" == document.location.protocol) ? "https://ssl." : "http://www.");
document.write(unescape("%3Cscript src='" + gaJsHost + "google-analytics.com/u/ga_debug.js' type='text/javascript'%3E%3C/script%3E"));
</script>

with

<script type="text/javascript" src="http://www.google-analytics.com/u/ga_debug.js"></script>

then pageTracker._trackPageview() executes without any errors.

[boblail]

I've narrowed down the exception. You can trigger it by calling just new Image(1, 1) rather than pageTracker._trackPageview() — after document.write-ing the ga.js include.

The test app is now: https://gist.github.com/845207

[boblail]

I pushed an implementation of Image just now; and Google Analytics appears to work without error.

Now, on to the problem with http://jsbin.com/js/render/edit.js ...

[boblail]

I think the problem is in jsdom. It looks like the following

var h = document.createElement('div');
h.innerHTML = '<div style=\"opacity:0.8\"></div>';
window.console.log(h.childNodes[0]);

yields undefined!

c.f. jsdom/jsdom#171

[ghost]

so has this been resolved?

[assaf]

Fixed in JSDOM