Skip to content

Commit

Permalink
Merge pull request couchrest#107 from Burgestrand/base-respond_to
Browse files Browse the repository at this point in the history
Add CouchRest::Model::Base.respond_to_missing? and respond_to?
  • Loading branch information
tapajos committed Aug 21, 2011
2 parents 44e09f6 + 72e3ac3 commit 29de792
Show file tree
Hide file tree
Showing 2 changed files with 31 additions and 1 deletion.
15 changes: 15 additions & 0 deletions lib/couchrest/model/base.rb
Expand Up @@ -82,6 +82,21 @@ def self.method_missing(m, *args, &block)
super
end

# compatbility for 1.8, it does not use respond_to_missing?
# thing is, when using it like this only, doing method(:find_by_view)
# will throw an error
def self.respond_to?(m, include_private = false)
super || respond_to_missing?(m, include_private)
end

# ruby 1.9 feature
# this allows ruby to know that the method is defined using
# method_missing, and as such, method(:find_by_view) will actually
# give a Method back, and not throw an error like in 1.8!
def self.respond_to_missing?(m, include_private = false)
has_view?(m) || has_view?(m.to_s[/^find_(by_.+)/, 1])
end

def to_key
new? ? nil : [id]
end
Expand Down
17 changes: 16 additions & 1 deletion spec/unit/view_spec.rb
Expand Up @@ -173,7 +173,22 @@ def self.database
end

end


describe "#method_missing for find_by methods" do
before(:all) { reset_test_db! }

specify { Course.should respond_to :find_by_title_and_active }
specify { Course.should respond_to :by_title }

specify "#method should work in ruby 1.9, but not 1.8" do
if RUBY_VERSION >= "1.9"
Course.method(:find_by_title_and_active).should be_a Method
else
expect { Course.method(:find_by_title_and_active) }.to raise_error(NameError)
end
end
end

describe "a ducktype view" do
before(:all) do
reset_test_db!
Expand Down

0 comments on commit 29de792

Please sign in to comment.