Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore only Gruntfile in root. #4

Merged
merged 1 commit into from
May 13, 2013

Conversation

johanneswuerbach
Copy link
Contributor

The template Gruntfile.js is missing in the npm package.

@hariadi
Copy link
Member

hariadi commented May 12, 2013

Thanks. But this Gruntfile.js required by Assemble. Can you explain please?

@johanneswuerbach
Copy link
Contributor Author

This Gruntfile https://github.com/hariadi/generator-assemble/blob/master/app/templates/Gruntfile.js is not included in the npm package (every Gruntfile is ignored) and the generator is not working if installed via npm.

This fix ignores only the Gruntfile in the root folder and generates all files into the package tar.

hariadi added a commit that referenced this pull request May 13, 2013
@hariadi hariadi merged commit 53dd4cb into assemble:master May 13, 2013
@sndrs
Copy link
Contributor

sndrs commented Jun 10, 2013

Has this gone on to npm?

Just ran yo assemble after npm install generator-assemble, and it throws the following error:

Error: ENOENT, no such file or directory [...]/node_modules/generator-assemble/app/templates/Gruntfile.js

Is this the same issue?

(manually adding https://github.com/hariadi/generator-assemble/blob/master/app/templates/Gruntfile.js work fine btw)

hariadi added a commit that referenced this pull request Jun 11, 2013
hariadi added a commit that referenced this pull request Jun 12, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants