Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warning from moment #1

Closed
ubenzer opened this issue Nov 6, 2014 · 2 comments
Closed

Deprecation warning from moment #1

ubenzer opened this issue Nov 6, 2014 · 2 comments

Comments

@ubenzer
Copy link

ubenzer commented Nov 6, 2014

When I use this library I see the following notice on the console:

Deprecation warning: moment.lang is deprecated. Use moment.locale instead.

I wanted to come up with a pull request however, when I did npm installon forked project root of yours I got:

npm verb git fetch -a origin (git://github.com/assemble/strings)
npm info git [ 'rev-list', '-n1', 'v0.3.0' ]
npm ERR! Failed resolving git HEAD (git://github.com/assemble/strings) fatal: ambiguous argument 'v0.3.0': unknown revision or path not in the working tree.
npm ERR! Failed resolving git HEAD (git://github.com/assemble/strings) Use '--' to separate paths from revisions, like this:
npm ERR! Failed resolving git HEAD (git://github.com/assemble/strings) 'git <command> [<revision>...] -- [<file>...]'
npm ERR! Failed resolving git HEAD (git://github.com/assemble/strings)


....

npm ERR! Darwin 14.0.0
npm ERR! argv "node" "/usr/local/bin/npm" "install"
npm ERR! node v0.10.33
npm ERR! npm  v2.1.6
npm ERR! code 128

npm ERR! Command failed: fatal: ambiguous argument 'v0.3.0': unknown revision or path not in the working tree.
npm ERR! Use '--' to separate paths from revisions, like this:
npm ERR! 'git <command> [<revision>...] -- [<file>...]'

Can you help me with those?

@doowb
Copy link
Owner

doowb commented Nov 6, 2014

Thanks for pointing this out. It looks like this repo is out of sync with the latest version of strings so even using the correct version is breaking a lot of the tests.

It might be a little bit before I have time to update the versions and the tests.

@doowb
Copy link
Owner

doowb commented Jul 9, 2015

closed via ecb53fa

@doowb doowb closed this as completed Jul 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants